DGS-21595 Allow alternate KMS key IDs on a KEK #2018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 All Contributor License Agreements have been signed. Ready to merge. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for alternate KMS key IDs on Key Encryption Keys (KEK) to provide fallback encryption/decryption capabilities. The implementation allows specifying multiple KMS key IDs that will be tried in sequence during encryption and decryption operations.
- Introduces a new
AeadWrapperclass that handles multiple KMS key IDs with fallback logic - Adds configuration support for alternate KMS key IDs via
encrypt.alternate.kms.key.ids - Implements retry logic that attempts encryption/decryption with each available key ID
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/confluent_kafka/schema_registry/rules/encryption/encrypt_executor.py | Implements the core functionality with AeadWrapper class and alternate KMS key ID support |
| tests/schema_registry/_sync/test_avro_serdes.py | Adds synchronous test case for alternate KEK functionality |
| tests/schema_registry/_async/test_avro_serdes.py | Adds asynchronous test case for alternate KEK functionality |
src/confluent_kafka/schema_registry/rules/encryption/encrypt_executor.py
Show resolved
Hide resolved
src/confluent_kafka/schema_registry/rules/encryption/encrypt_executor.py
Show resolved
Hide resolved
src/confluent_kafka/schema_registry/rules/encryption/encrypt_executor.py
Outdated
Show resolved
Hide resolved
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
multiple-kek
branch
from
c97bb9a to
4ac37c3
Compare
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
multiple-kek
branch
from
4ac37c3 to
90b65bd
Compare
This comment has been minimized.
This comment has been minimized.
airlock-confluentinc
bot
force-pushed
the
multiple-kek
branch
from
90b65bd to
431f3d5
Compare
Analysis Details14 Issues
Coverage and Duplications
Project ID: confluent-kafka-python |
Claimundefine
approved these changes
Aug 19, 2025
Claimundefine
approved these changes
Aug 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Checklist
References
JIRA:
Test & Review
Open questions / Follow-ups